summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Robillard <d@drobilla.net>2020-08-01 14:32:01 +0200
committerDavid Robillard <d@drobilla.net>2020-08-02 01:48:48 +0200
commita9450b3903b93a5d86c1295d12a4786791186361 (patch)
tree357a5b3dcf7d565b78118b1b1eb1879d34dfac16
parent6a1ce7d1ee5e6f20aa011fe994341d9d79ac35ea (diff)
downloadingen-a9450b3903b93a5d86c1295d12a4786791186361.tar.gz
ingen-a9450b3903b93a5d86c1295d12a4786791186361.tar.bz2
ingen-a9450b3903b93a5d86c1295d12a4786791186361.zip
Remove redundant base class initializations
-rw-r--r--.clang-tidy1
-rw-r--r--src/gui/BreadCrumbs.cpp3
-rw-r--r--src/gui/Window.hpp4
3 files changed, 3 insertions, 5 deletions
diff --git a/.clang-tidy b/.clang-tidy
index d4ee6314..65678a11 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -75,7 +75,6 @@ Checks: >
-readability-else-after-return,
-readability-implicit-bool-conversion,
-readability-named-parameter,
- -readability-redundant-member-init,
-readability-static-accessed-through-instance,
WarningsAsErrors: '*'
HeaderFilterRegex: 'ingen/.*|tests/.*|src/.*'
diff --git a/src/gui/BreadCrumbs.cpp b/src/gui/BreadCrumbs.cpp
index d641f5ac..a4a1b2fb 100644
--- a/src/gui/BreadCrumbs.cpp
+++ b/src/gui/BreadCrumbs.cpp
@@ -30,8 +30,7 @@ namespace gui {
using std::string;
BreadCrumbs::BreadCrumbs(App& app)
- : Gtk::HBox()
- , _active_path("/")
+ : _active_path("/")
, _full_path("/")
, _enable_signal(true)
{
diff --git a/src/gui/Window.hpp b/src/gui/Window.hpp
index 5f49bc10..ab3586fc 100644
--- a/src/gui/Window.hpp
+++ b/src/gui/Window.hpp
@@ -33,7 +33,7 @@ class App;
class Window : public Gtk::Window
{
public:
- Window() : Gtk::Window(), _app(nullptr) {}
+ Window() : _app(nullptr) {}
explicit Window(BaseObjectType* cobject) : Gtk::Window(cobject), _app(nullptr) {}
virtual void init_window(App& app) { _app = &app; }
@@ -57,7 +57,7 @@ public:
class Dialog : public Gtk::Dialog
{
public:
- Dialog() : Gtk::Dialog(), _app(nullptr) {}
+ Dialog() : _app(nullptr) {}
explicit Dialog(BaseObjectType* cobject) : Gtk::Dialog(cobject), _app(nullptr) {}
virtual void init_dialog(App& app) { _app = &app; }