diff options
| -rw-r--r-- | .clang-tidy | 1 | ||||
| -rw-r--r-- | src/client/ClientStore.cpp | 4 | ||||
| -rw-r--r-- | src/client/ObjectModel.cpp | 2 | ||||
| -rw-r--r-- | src/client/PluginModel.cpp | 2 | ||||
| -rw-r--r-- | src/client/PortModel.cpp | 2 | ||||
| -rw-r--r-- | src/gui/GraphCanvas.cpp | 4 | ||||
| -rw-r--r-- | src/gui/LoadGraphWindow.cpp | 2 | ||||
| -rw-r--r-- | wscript | 1 |
8 files changed, 8 insertions, 10 deletions
diff --git a/.clang-tidy b/.clang-tidy index c714a9a4..141a0bc1 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -67,7 +67,6 @@ Checks: > -modernize-use-default-member-init, -modernize-use-trailing-return-type, -modernize-use-using, - -performance-for-range-copy, -performance-no-automatic-move, -performance-type-promotion-in-math-fn, -performance-unnecessary-value-param, diff --git a/src/client/ClientStore.cpp b/src/client/ClientStore.cpp index a42efd16..64489b49 100644 --- a/src/client/ClientStore.cpp +++ b/src/client/ClientStore.cpp @@ -84,7 +84,7 @@ ClientStore::add_object(SPtr<ObjectModel> object) } } - for (auto p : object->properties()) { + for (const auto& p : object->properties()) { object->signal_property().emit(p.first, p.second); } } @@ -475,7 +475,7 @@ ClientStore::operator()(const DisconnectAll& msg) } const GraphModel::Arcs arcs = graph->arcs(); - for (auto a : arcs) { + for (const auto& a : arcs) { SPtr<ArcModel> arc = dynamic_ptr_cast<ArcModel>(a.second); if (arc->tail()->parent() == object || arc->head()->parent() == object diff --git a/src/client/ObjectModel.cpp b/src/client/ObjectModel.cpp index b1a27590..78337270 100644 --- a/src/client/ObjectModel.cpp +++ b/src/client/ObjectModel.cpp @@ -88,7 +88,7 @@ ObjectModel::set(const SPtr<ObjectModel>& o) _parent = o->_parent; } - for (auto v : o->properties()) { + for (const auto& v : o->properties()) { Resource::set_property(v.first, v.second); _signal_property.emit(v.first, v.second); } diff --git a/src/client/PluginModel.cpp b/src/client/PluginModel.cpp index eaa70b9e..744bdb7d 100644 --- a/src/client/PluginModel.cpp +++ b/src/client/PluginModel.cpp @@ -161,7 +161,7 @@ PluginModel::set(SPtr<PluginModel> p) _lilv_plugin = p->_lilv_plugin; } - for (auto v : p->properties()) { + for (const auto& v : p->properties()) { Resource::set_property(v.first, v.second); _signal_property.emit(v.first, v.second); } diff --git a/src/client/PortModel.cpp b/src/client/PortModel.cpp index 6b2d011f..fa1a7abe 100644 --- a/src/client/PortModel.cpp +++ b/src/client/PortModel.cpp @@ -55,7 +55,7 @@ bool PortModel::is_uri() const { // FIXME: Resource::has_property doesn't work, URI != URID - for (auto p : properties()) { + for (const auto& p : properties()) { if (p.second.type() == _uris.atom_URID && static_cast<LV2_URID>(p.second.get<int32_t>()) == _uris.atom_URID) { return true; diff --git a/src/gui/GraphCanvas.cpp b/src/gui/GraphCanvas.cpp index 391b8729..bd75c352 100644 --- a/src/gui/GraphCanvas.cpp +++ b/src/gui/GraphCanvas.cpp @@ -400,7 +400,7 @@ GraphCanvas::get_port_view(const SPtr<PortModel>& port) } else { module = dynamic_cast<NodeModule*>(_views[port->parent()]); if (module) { - for (const auto& p : *module) { + for (auto* p : *module) { gui::Port* pv = dynamic_cast<gui::Port*>(p); if (pv && pv->model() == port) { return pv; @@ -777,7 +777,7 @@ GraphCanvas::paste() } // Connect objects - for (auto a : clipboard.object(Raul::Path("/"))->arcs()) { + for (const auto& a : clipboard.object(Raul::Path("/"))->arcs()) { _app.interface()->connect( avoider.map_path(parent.child(a.second->tail_path())), avoider.map_path(parent.child(a.second->head_path()))); diff --git a/src/gui/LoadGraphWindow.cpp b/src/gui/LoadGraphWindow.cpp index 62c68b04..cb1d4de9 100644 --- a/src/gui/LoadGraphWindow.cpp +++ b/src/gui/LoadGraphWindow.cpp @@ -181,7 +181,7 @@ LoadGraphWindow::ok_clicked() } else { std::list<Glib::ustring> uri_list = get_filenames(); - for (auto u : uri_list) { + for (const auto& u : uri_list) { // Cascade Atom& x = _initial_data.find(uris.ingen_canvasX)->second; x = _app->forge().make(x.get<float>() + 20.0f); @@ -78,7 +78,6 @@ def configure(conf): '-Wno-implicit-int-conversion', '-Wno-inconsistent-missing-destructor-override', '-Wno-padded', - '-Wno-range-loop-bind-reference', '-Wno-reserved-id-macro', '-Wno-return-std-move-in-c++11', '-Wno-shadow', |