diff options
-rw-r--r-- | include/ingen/LV2Features.hpp | 2 | ||||
-rw-r--r-- | include/ingen/Module.hpp | 3 | ||||
-rw-r--r-- | include/ingen/Tee.hpp | 2 | ||||
-rw-r--r-- | include/ingen/client/ClientStore.hpp | 14 | ||||
-rw-r--r-- | include/ingen/memory.hpp | 4 | ||||
-rw-r--r-- | src/gui/PluginMenu.hpp | 4 | ||||
-rw-r--r-- | src/server/ControlBindings.hpp | 8 | ||||
-rw-r--r-- | src/server/Event.hpp | 5 | ||||
-rw-r--r-- | src/server/EventWriter.hpp | 4 | ||||
-rw-r--r-- | src/server/LV2Block.hpp | 2 | ||||
-rw-r--r-- | src/server/PortImpl.hpp | 4 | ||||
-rw-r--r-- | src/server/PortType.hpp | 2 | ||||
-rw-r--r-- | src/server/PostProcessor.cpp | 2 | ||||
-rw-r--r-- | src/server/UndoStack.cpp | 4 | ||||
-rw-r--r-- | src/server/UndoStack.hpp | 7 | ||||
-rw-r--r-- | src/server/Worker.hpp | 2 | ||||
-rw-r--r-- | tests/TestClient.hpp | 2 |
17 files changed, 42 insertions, 29 deletions
diff --git a/include/ingen/LV2Features.hpp b/include/ingen/LV2Features.hpp index f61b9b85..61183932 100644 --- a/include/ingen/LV2Features.hpp +++ b/include/ingen/LV2Features.hpp @@ -52,7 +52,7 @@ public: class EmptyFeature : public Feature { public: - explicit EmptyFeature(const char* uri) : _uri(uri) {} + explicit EmptyFeature(const char* uri) noexcept : _uri(uri) {} const char* uri() const override { return _uri; } diff --git a/include/ingen/Module.hpp b/include/ingen/Module.hpp index 149c25f9..8fe7b923 100644 --- a/include/ingen/Module.hpp +++ b/include/ingen/Module.hpp @@ -33,7 +33,8 @@ class World; */ class INGEN_API Module { public: - Module() : library(nullptr) {} + Module() noexcept : library(nullptr) {} + virtual ~Module() = default; Module(const Module&) = delete; diff --git a/include/ingen/Tee.hpp b/include/ingen/Tee.hpp index 1e6805cc..2158190f 100644 --- a/include/ingen/Tee.hpp +++ b/include/ingen/Tee.hpp @@ -34,7 +34,7 @@ class Tee : public Interface public: using Sinks = std::vector<std::shared_ptr<Interface>>; - explicit Tee(Sinks sinks) : _sinks(std::move(sinks)) {} + explicit Tee(Sinks sinks) noexcept : _sinks(std::move(sinks)) {} std::shared_ptr<Interface> respondee() const override { return _sinks.front()->respondee(); diff --git a/include/ingen/client/ClientStore.hpp b/include/ingen/client/ClientStore.hpp index 3aec363f..83cce726 100644 --- a/include/ingen/client/ClientStore.hpp +++ b/include/ingen/client/ClientStore.hpp @@ -78,22 +78,22 @@ public: void message(const Message& msg) override; - void operator()(const BundleBegin&) {} - void operator()(const BundleEnd&) {} + void operator()(const BundleBegin&) noexcept {} + void operator()(const BundleEnd&) noexcept {} void operator()(const Connect&); void operator()(const Copy&); void operator()(const Del&); void operator()(const Delta&); void operator()(const Disconnect&); void operator()(const DisconnectAll&); - void operator()(const Error&) {} - void operator()(const Get&) {} + void operator()(const Error&) noexcept {} + void operator()(const Get&) noexcept {} void operator()(const Move&); void operator()(const Put&); - void operator()(const Redo&) {} - void operator()(const Response&) {} + void operator()(const Redo&) noexcept {} + void operator()(const Response&) noexcept {} void operator()(const SetProperty&); - void operator()(const Undo&) {} + void operator()(const Undo&) noexcept {} INGEN_SIGNAL(new_object, void, std::shared_ptr<ObjectModel>) INGEN_SIGNAL(new_plugin, void, std::shared_ptr<PluginModel>) diff --git a/include/ingen/memory.hpp b/include/ingen/memory.hpp index 7d2e1db0..a1dba436 100644 --- a/include/ingen/memory.hpp +++ b/include/ingen/memory.hpp @@ -22,10 +22,10 @@ namespace ingen { template <class T> -void NullDeleter(T* ptr) {} +void NullDeleter(T* ptr) noexcept {} template <class T> -struct FreeDeleter { void operator()(T* const ptr) { free(ptr); } }; +struct FreeDeleter { void operator()(T* const ptr) noexcept { free(ptr); } }; } // namespace ingen diff --git a/src/gui/PluginMenu.hpp b/src/gui/PluginMenu.hpp index 2cf130bb..4df5cb24 100644 --- a/src/gui/PluginMenu.hpp +++ b/src/gui/PluginMenu.hpp @@ -57,7 +57,9 @@ public: private: struct MenuRecord { - MenuRecord(Gtk::MenuItem* i, Gtk::Menu* m) : item(i), menu(m) {} + MenuRecord(Gtk::MenuItem* i, Gtk::Menu* m) noexcept : item(i), menu(m) + {} + Gtk::MenuItem* item; Gtk::Menu* menu; }; diff --git a/src/server/ControlBindings.hpp b/src/server/ControlBindings.hpp index 1c231e22..e71befa1 100644 --- a/src/server/ControlBindings.hpp +++ b/src/server/ControlBindings.hpp @@ -64,15 +64,21 @@ public: }; struct Key { - Key(Type t=Type::NULL_CONTROL, int16_t n=0) : type(t), num(n) {} + Key(Type t = Type::NULL_CONTROL, int16_t n = 0) noexcept + : type(t), num(n) + {} + inline bool operator<(const Key& other) const { return ((type < other.type) || (type == other.type && num < other.num)); } + inline bool operator==(const Key& other) const { return type == other.type && num == other.num; } + inline bool operator!() const { return type == Type::NULL_CONTROL; } + Type type; int16_t num; }; diff --git a/src/server/Event.hpp b/src/server/Event.hpp index e00aa0d1..53d33e89 100644 --- a/src/server/Event.hpp +++ b/src/server/Event.hpp @@ -114,7 +114,10 @@ public: inline Engine& engine() { return _engine; } protected: - Event(Engine& engine, std::shared_ptr<Interface> client, int32_t id, FrameTime time) + Event(Engine& engine, + std::shared_ptr<Interface> client, + int32_t id, + FrameTime time) noexcept : _engine(engine) , _next(nullptr) , _request_client(std::move(client)) diff --git a/src/server/EventWriter.hpp b/src/server/EventWriter.hpp index 184cefb7..437f65a5 100644 --- a/src/server/EventWriter.hpp +++ b/src/server/EventWriter.hpp @@ -62,12 +62,12 @@ public: void operator()(const Delta&); void operator()(const Disconnect&); void operator()(const DisconnectAll&); - void operator()(const Error&) {} + void operator()(const Error&) noexcept {} void operator()(const Get&); void operator()(const Move&); void operator()(const Put&); void operator()(const Redo&); - void operator()(const Response&) {} + void operator()(const Response&) noexcept {} void operator()(const SetProperty&); void operator()(const Undo&); diff --git a/src/server/LV2Block.hpp b/src/server/LV2Block.hpp index c8f9e59a..77270234 100644 --- a/src/server/LV2Block.hpp +++ b/src/server/LV2Block.hpp @@ -125,7 +125,7 @@ public: protected: struct Instance : public raul::Noncopyable { - explicit Instance(LilvInstance* i) : instance(i) {} + explicit Instance(LilvInstance* i) noexcept : instance(i) {} ~Instance() { lilv_instance_free(instance); } diff --git a/src/server/PortImpl.hpp b/src/server/PortImpl.hpp index ee3a2bf8..11c82539 100644 --- a/src/server/PortImpl.hpp +++ b/src/server/PortImpl.hpp @@ -91,10 +91,8 @@ public: }; struct Voice { - Voice() : buffer(nullptr) {} - SetState set_state; - BufferRef buffer; + BufferRef buffer{nullptr}; }; using Voices = raul::Array<Voice>; diff --git a/src/server/PortType.hpp b/src/server/PortType.hpp index f84c271f..d67429c9 100644 --- a/src/server/PortType.hpp +++ b/src/server/PortType.hpp @@ -56,7 +56,7 @@ public: } } - PortType(ID id) : _id(id) {} + PortType(ID id) noexcept : _id(id) {} inline const URI& uri() const { return type_uri(_id); } inline ID id() const { return _id; } diff --git a/src/server/PostProcessor.cpp b/src/server/PostProcessor.cpp index 5a0a8f3e..a4f94fe9 100644 --- a/src/server/PostProcessor.cpp +++ b/src/server/PostProcessor.cpp @@ -28,7 +28,7 @@ class PreProcessContext; class Sentinel : public Event { public: - explicit Sentinel(Engine& engine) : Event(engine) {} + explicit Sentinel(Engine& engine) noexcept : Event(engine) {} bool pre_process(PreProcessContext&) override { return false; } void execute(RunContext&) override {} diff --git a/src/server/UndoStack.cpp b/src/server/UndoStack.cpp index 40c59af5..3dd4b3b0 100644 --- a/src/server/UndoStack.cpp +++ b/src/server/UndoStack.cpp @@ -118,7 +118,7 @@ UndoStack::pop() } struct BlankIDs { - explicit BlankIDs(char prefix='b') : c(prefix) {} + explicit BlankIDs(const char prefix = 'b') noexcept : c{prefix} {} SerdNode get() { snprintf(buf, sizeof(buf), "%c%u", c, n++); @@ -127,7 +127,7 @@ struct BlankIDs { char buf[16]{}; unsigned n{0}; - const char c{'b'}; + const char c; }; struct ListContext { diff --git a/src/server/UndoStack.hpp b/src/server/UndoStack.hpp index 713ad777..a6d90e9c 100644 --- a/src/server/UndoStack.hpp +++ b/src/server/UndoStack.hpp @@ -42,7 +42,7 @@ namespace server { class INGEN_SERVER_API UndoStack : public AtomSink { public: struct Entry { - Entry(time_t t=0) : time(t) {} + Entry(time_t t = 0) noexcept : time(t) {} Entry(const Entry& copy) : time(copy.time) @@ -83,7 +83,10 @@ public: std::deque<LV2_Atom*> events; }; - UndoStack(URIs& uris, URIMap& map) : _uris(uris), _map(map), _depth(0) {} + UndoStack(URIs& uris, URIMap& map) noexcept + : _uris(uris), _map(map), _depth(0) + { + } int start_entry(); bool write(const LV2_Atom* msg, int32_t default_id=0) override; diff --git a/src/server/Worker.hpp b/src/server/Worker.hpp index dd799174..ed9a2470 100644 --- a/src/server/Worker.hpp +++ b/src/server/Worker.hpp @@ -44,7 +44,7 @@ public: ~Worker(); struct Schedule : public LV2Features::Feature { - Schedule(bool sync) : synchronous(sync) {} + Schedule(bool sync) noexcept : synchronous(sync) {} const char* uri() const override { return LV2_WORKER__schedule; } diff --git a/tests/TestClient.hpp b/tests/TestClient.hpp index da749660..f282ee6d 100644 --- a/tests/TestClient.hpp +++ b/tests/TestClient.hpp @@ -32,7 +32,7 @@ namespace ingen { class TestClient : public Interface { public: - explicit TestClient(Log& log) : _log(log) {} + explicit TestClient(Log& log) noexcept : _log(log) {} ~TestClient() override = default; |