diff options
author | David Robillard <d@drobilla.net> | 2020-12-14 16:14:59 +0100 |
---|---|---|
committer | David Robillard <d@drobilla.net> | 2020-12-14 16:14:59 +0100 |
commit | 119a36c04b4b06c4a67543f8f8397aed1d556aea (patch) | |
tree | 870f66365636d55e5145338f45da9ffb28243b32 | |
parent | 778ff7201a2e3fcc9409f91ee83f2e8a962debf9 (diff) | |
download | jalv-119a36c04b4b06c4a67543f8f8397aed1d556aea.tar.gz jalv-119a36c04b4b06c4a67543f8f8397aed1d556aea.tar.bz2 jalv-119a36c04b4b06c4a67543f8f8397aed1d556aea.zip |
Fix unused parameter warnings
-rw-r--r-- | .clang-tidy | 1 | ||||
-rw-r--r-- | src/jalv_console.c | 7 | ||||
-rw-r--r-- | src/jalv_gtk.c | 6 | ||||
-rw-r--r-- | src/jalv_gtkmm2.cpp | 8 | ||||
-rw-r--r-- | src/jalv_qt.cpp | 12 | ||||
-rw-r--r-- | src/lv2_evbuf.c | 2 |
6 files changed, 19 insertions, 17 deletions
diff --git a/.clang-tidy b/.clang-tidy index 6cbee5d..e84fb51 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -36,7 +36,6 @@ Checks: > -llvm-header-guard, -llvmlibc-*, -misc-no-recursion, - -misc-unused-parameters, -modernize-return-braced-init-list, -modernize-use-trailing-return-type, -modernize-use-using, diff --git a/src/jalv_console.c b/src/jalv_console.c index d000826..2d6ea84 100644 --- a/src/jalv_console.c +++ b/src/jalv_console.c @@ -25,6 +25,7 @@ #include "lilv/lilv.h" #include "lv2/ui/ui.h" #include "suil/suil.h" +#include "zix/common.h" #include "zix/sem.h" #include <stdbool.h> @@ -152,10 +153,10 @@ jalv_print_controls(Jalv* jalv, bool writable, bool readable) } static int -jalv_print_preset(Jalv* jalv, +jalv_print_preset(Jalv* ZIX_UNUSED(jalv), const LilvNode* node, const LilvNode* title, - void* data) + void* ZIX_UNUSED(data)) { printf("%s (%s)\n", lilv_node_as_string(node), lilv_node_as_string(title)); return 0; @@ -260,7 +261,7 @@ jalv_run_custom_ui(Jalv* jalv) } float -jalv_ui_refresh_rate(Jalv* jalv) +jalv_ui_refresh_rate(Jalv* ZIX_UNUSED(jalv)) { return 30.0f; } diff --git a/src/jalv_gtk.c b/src/jalv_gtk.c index 0f2a028..305ae49 100644 --- a/src/jalv_gtk.c +++ b/src/jalv_gtk.c @@ -651,8 +651,8 @@ patch_put_get(Jalv* jalv, static LV2UI_Request_Value_Status on_request_value(LV2UI_Feature_Handle handle, const LV2_URID key, - const LV2_URID type, - const LV2_Feature* const* features) + const LV2_URID ZIX_UNUSED(type), + const LV2_Feature* const* ZIX_UNUSED(features)) { Jalv* jalv = (Jalv*)handle; ControlID* control = get_property_control(&jalv->controls, key); @@ -1208,7 +1208,7 @@ jalv_discover_ui(Jalv* ZIX_UNUSED(jalv)) } float -jalv_ui_refresh_rate(Jalv* jalv) +jalv_ui_refresh_rate(Jalv* ZIX_UNUSED(jalv)) { #if GTK_MAJOR_VERSION == 2 return 30.0f; diff --git a/src/jalv_gtkmm2.cpp b/src/jalv_gtkmm2.cpp index cdc7f74..74f3a38 100644 --- a/src/jalv_gtkmm2.cpp +++ b/src/jalv_gtkmm2.cpp @@ -34,7 +34,7 @@ LV2_RESTORE_WARNINGS static Gtk::Main* jalv_gtk_main = nullptr; int -jalv_init(int* argc, char*** argv, JalvOptions* opts) +jalv_init(int* argc, char*** argv, JalvOptions*) { jalv_gtk_main = new Gtk::Main(*argc, *argv); return 0; @@ -60,13 +60,13 @@ jalv_ui_port_event(Jalv* jalv, } bool -jalv_discover_ui(Jalv* jalv) +jalv_discover_ui(Jalv*) { return true; } float -jalv_ui_refresh_rate(Jalv* jalv) +jalv_ui_refresh_rate(Jalv*) { return 30.0f; } @@ -111,7 +111,7 @@ jalv_open_ui(Jalv* jalv) } int -jalv_close_ui(Jalv* jalv) +jalv_close_ui(Jalv*) { Gtk::Main::quit(); return 0; diff --git a/src/jalv_qt.cpp b/src/jalv_qt.cpp index b3b5a38..2e18446 100644 --- a/src/jalv_qt.cpp +++ b/src/jalv_qt.cpp @@ -347,7 +347,7 @@ private: extern "C" { int -jalv_init(int* argc, char*** argv, JalvOptions* opts) +jalv_init(int* argc, char*** argv, JalvOptions*) { app = new QApplication(*argc, *argv, true); app->setStyleSheet("QGroupBox::title { subcontrol-position: top center }"); @@ -388,7 +388,7 @@ class Timer : public QTimer public: explicit Timer(Jalv* jalv) : _jalv(jalv) {} - void timerEvent(QTimerEvent* e) override { + void timerEvent(QTimerEvent*) override { jalv_update(_jalv); } @@ -592,7 +592,7 @@ Control::stringWidth(const QString& str) } void -Control::dialChanged(int dialValue) +Control::dialChanged(int) { float value = getValue(); @@ -694,13 +694,13 @@ build_control_widget(Jalv* jalv) } bool -jalv_discover_ui(Jalv* jalv) +jalv_discover_ui(Jalv*) { return true; } float -jalv_ui_refresh_rate(Jalv* jalv) +jalv_ui_refresh_rate(Jalv*) { #if QT_VERSION >= 0x050000 return (float)QGuiApplication::primaryScreen()->refreshRate(); @@ -770,7 +770,7 @@ jalv_open_ui(Jalv* jalv) } int -jalv_close_ui(Jalv* jalv) +jalv_close_ui(Jalv*) { app->quit(); return 0; diff --git a/src/lv2_evbuf.c b/src/lv2_evbuf.c index 8cc667d..9085983 100644 --- a/src/lv2_evbuf.c +++ b/src/lv2_evbuf.c @@ -158,6 +158,8 @@ lv2_evbuf_write(LV2_Evbuf_Iterator* iter, uint32_t size, const uint8_t* data) { + (void)subframes; + LV2_Atom_Sequence* aseq = &iter->evbuf->buf; if (iter->evbuf->capacity - sizeof(LV2_Atom) - aseq->atom.size < sizeof(LV2_Atom_Event) + size) { |