diff options
| author | David Robillard <d@drobilla.net> | 2022-06-29 13:37:11 -0400 |
|---|---|---|
| committer | David Robillard <d@drobilla.net> | 2022-08-17 13:50:37 -0400 |
| commit | 913c0bfecec19f30faf106c977e4e1b373338fd5 (patch) | |
| tree | 8acf24a7bb898dd9e186e06ace5968fc228970ce | |
| parent | 569c13dc8e3bbce6c4a78f967754e1afe301f4d8 (diff) | |
| download | jalv-913c0bfecec19f30faf106c977e4e1b373338fd5.tar.gz jalv-913c0bfecec19f30faf106c977e4e1b373338fd5.tar.bz2 jalv-913c0bfecec19f30faf106c977e4e1b373338fd5.zip | |
Use C++14
| -rw-r--r-- | .clang-tidy | 4 | ||||
| -rw-r--r-- | src/jalv_qt.cpp | 8 |
2 files changed, 4 insertions, 8 deletions
diff --git a/.clang-tidy b/.clang-tidy index 6699db9..36b646f 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -1,7 +1,6 @@ Checks: > *, -*-c-arrays, - -*-deprecated-headers, -*-magic-numbers, -*-named-parameter, -*-narrowing-conversions, @@ -31,10 +30,7 @@ Checks: > -llvm-header-guard, -llvmlibc-*, -misc-no-recursion, - -modernize-redundant-void-arg, - -modernize-use-nullptr, -modernize-use-trailing-return-type, - -modernize-use-using, -readability-function-cognitive-complexity, -readability-implicit-bool-conversion, -readability-non-const-parameter, diff --git a/src/jalv_qt.cpp b/src/jalv_qt.cpp index 15aa05f..f9cf3b5 100644 --- a/src/jalv_qt.cpp +++ b/src/jalv_qt.cpp @@ -48,12 +48,12 @@ #include <map> #include <vector> -#define CONTROL_WIDTH 150 -#define DIAL_STEPS 10000 +constexpr int CONTROL_WIDTH = 150; +constexpr int DIAL_STEPS = 10000; static QApplication* app = nullptr; -class FlowLayout : public QLayout +class FlowLayout final : public QLayout { public: explicit FlowLayout(QWidget* parent, int margin, int hSpacing, int vSpacing); @@ -590,7 +590,7 @@ build_control_widget(Jalv* jalv) LilvNode* group = lilv_port_get(plugin, port->lilv_port, jalv->nodes.pg_group); if (group) { - if (!lilv_node_equals(group, lastGroup)) { + if (!groupLayout || !lilv_node_equals(group, lastGroup)) { // Group has changed LilvNode* groupName = lilv_world_get(world, group, jalv->nodes.lv2_name, nullptr); |