Replace strict option with new meson warning level

6 files changed, 138 insertions, 338 deletions

diff --git a/.reuse/dep5 b/.reuse/dep5
index 771c0b4..110b66c 100644
--- a/.reuse/dep5
+++ b/.reuse/dep5
@@ -3,7 +3,7 @@ Upstream-Name: jalv
 Upstream-Contact: David Robillard <d@drobilla.net>
 Source: https://gitlab.com/drobilla/jalv
 
-Files: .clang* .clant.json .gitignore AUTHORS NEWS jalv.desktop.in jalv.ttl meson_options.txt
+Files: .clang* .clant.json .gitignore AUTHORS NEWS jalv.desktop.in jalv.ttl
 Copyright: 2010-2022 David Robillard <d@drobilla.net>
 License: 0BSD OR ISC
 
diff --git a/meson.build b/meson.build
index e5454e9..36e991e 100644
--- a/meson.build
+++ b/meson.build
@@ -28,11 +28,6 @@ if add_languages(['cpp'], native: false, required: get_option('cxx'))
   cpp = meson.get_compiler('cpp')
 endif
 
-# Set global warning flags
-if get_option('strict') and not meson.is_subproject()
-  subdir('meson/warnings')
-endif
-
 # Set global warning suppressions
 subdir('meson/suppressions')
 add_project_arguments(c_suppressions, language: ['c'])
@@ -131,15 +126,19 @@ suil_dep = dependency(
 # Drivers #
 ###########
 
-portaudio_dep = dependency('portaudio-2.0',
-                           version: '>= 2.0.0',
-                           include_type: 'system',
-                           required: get_option('portaudio'))
+portaudio_dep = dependency(
+  'portaudio-2.0',
+  include_type: 'system',
+  required: get_option('portaudio'),
+  version: '>= 2.0.0',
+)
 
-jack_dep = dependency('jack',
-                      version: '>= 0.120.0',
-                      include_type: 'system',
-                      required: get_option('jack'))
+jack_dep = dependency(
+  'jack',
+  include_type: 'system',
+  required: get_option('jack'),
+  version: '>= 0.120.0',
+)
 
 backend_sources = files()
 if get_option('jack').enabled() and get_option('portaudio').enabled()
@@ -191,11 +190,13 @@ else
   ]
 endif
 
-# Check for platform features with the build system
-if get_option('checks')
-  platform_defines += [
-    '-DJALV_NO_DEFAULT_CONFIG',
-  ]
+# Build platform-specific configuration arguments
+if get_option('checks').disabled()
+  # Generic build without platform-specific features
+  platform_defines += ['-DJALV_NO_DEFAULT_CONFIG']
+elif get_option('checks').enabled()
+  # Only use the features detected by the build system
+  platform_defines += ['-DJALV_NO_DEFAULT_CONFIG']
 
   if no_posix
     platform_defines += ['-DHAVE_FILENO=0']
diff --git a/meson/suppressions/meson.build b/meson/suppressions/meson.build
index 51383dc..51aefc7 100644
--- a/meson/suppressions/meson.build
+++ b/meson/suppressions/meson.build
@@ -1,65 +1,9 @@
-# Copyright 2020-2022 David Robillard <d@drobilla.net>
+# Copyright 2020-2023 David Robillard <d@drobilla.net>
 # SPDX-License-Identifier: 0BSD OR ISC
 
-# Project-specific warning suppressions.
-#
-# This should be used in conjunction with the generic "warnings" sibling that
-# enables all reasonable warnings for the compiler.  It lives here just to keep
-# the top-level meson.build more readable.
-
-clang_common_suppressions = [
-  '-Wno-atomic-implicit-seq-cst',
-  '-Wno-c99-extensions',
-  '-Wno-cast-align',
-  '-Wno-cast-qual',
-  '-Wno-disabled-macro-expansion',
-  '-Wno-documentation-unknown-command',
-  '-Wno-double-promotion',
-  '-Wno-float-conversion',
-  '-Wno-float-equal',
-  '-Wno-format-nonliteral',
-  '-Wno-implicit-fallthrough',
-  '-Wno-implicit-float-conversion',
-  '-Wno-nullability-extension',
-  '-Wno-padded',
-  '-Wno-redundant-parens',
-  '-Wno-reserved-id-macro',
-  '-Wno-reserved-identifier',
-  '-Wno-shorten-64-to-32',
-  '-Wno-sign-conversion',
-  '-Wno-switch-enum',
-  '-Wno-unknown-warning-option',
-  '-Wno-unused-macros',
-  '-Wno-unused-parameter',
-]
-
-gcc_common_suppressions = [
-  '-Wno-cast-align',
-  '-Wno-cast-qual',
-  '-Wno-conversion',
-  '-Wno-double-promotion',
-  '-Wno-float-conversion',
-  '-Wno-float-equal',
-  '-Wno-inline',
-  '-Wno-padded',
-  '-Wno-pedantic',
-  '-Wno-stack-protector',
-  '-Wno-switch-default',
-  '-Wno-switch-enum',
-  '-Wno-unused-macros',
-  '-Wno-unused-parameter',
-]
-
-if host_machine.system() == 'darwin'
-  clang_common_suppressions += [
-    '-Wno-documentation', # JACK
-    '-Wno-documentation-deprecated-sync', # JACK
-  ]
-elif host_machine.system() == 'freebsd'
-  clang_common_suppressions += [
-    '-Wno-c11-extensions', # isnan and friends
-  ]
-endif
+# Project-specific warning suppressions
+
+warning_level = get_option('warning_level')
 
 #####
 # C #
@@ -68,28 +12,91 @@ endif
 if is_variable('cc')
   c_suppressions = []
 
-  if get_option('strict')
-    if cc.get_id() == 'clang'
-      c_suppressions += clang_common_suppressions + [
+  if cc.get_id() == 'clang'
+    if warning_level == 'everything'
+      c_suppressions += [
         '-Wno-bad-function-cast',
+        '-Wno-cast-align',
+        '-Wno-cast-qual',
         '-Wno-declaration-after-statement',
+        '-Wno-disabled-macro-expansion',
+        '-Wno-documentation-unknown-command', # MacOS
+        '-Wno-double-promotion',
+        '-Wno-float-conversion',
+        '-Wno-float-equal',
+        '-Wno-format-nonliteral',
+        '-Wno-implicit-float-conversion',
         '-Wno-missing-noreturn',
+        '-Wno-padded',
+        '-Wno-reserved-id-macro', # MacOS
+        '-Wno-shorten-64-to-32',
+        '-Wno-sign-conversion',
+        '-Wno-switch-enum',
+        '-Wno-unused-macros',
+      ]
+
+      if not meson.is_cross_build()
+        c_suppressions += [
+          '-Wno-poison-system-directories',
+        ]
+      endif
+    endif
+
+    if warning_level in ['everything', '3']
+      c_suppressions += [
+        '-Wno-nullability-extension',
+      ]
+    endif
+
+    if warning_level in ['everything', '3', '2']
+      c_suppressions += [
+        '-Wno-unused-parameter',
       ]
+    endif
 
-    elif cc.get_id() == 'gcc'
-      c_suppressions += gcc_common_suppressions + [
-        '-Wno-array-bounds',
+    if host_machine.system() == 'darwin'
+      c_suppressions += [
+        '-Wno-documentation', # JACK
+        '-Wno-documentation-deprecated-sync', # JACK
+      ]
+    elif host_machine.system() == 'freebsd'
+      c_suppressions += [
+        '-Wno-c11-extensions', # isnan and friends
+      ]
+    endif
+
+  elif cc.get_id() == 'gcc'
+    if warning_level == 'everything'
+      c_suppressions += [
         '-Wno-bad-function-cast',
         '-Wno-c++-compat',
+        '-Wno-cast-align',
+        '-Wno-cast-qual',
+        '-Wno-conversion',
+        '-Wno-double-promotion',
+        '-Wno-float-equal',
         '-Wno-format-nonliteral',
+        '-Wno-inline',
+        '-Wno-padded',
         '-Wno-strict-overflow',
         '-Wno-suggest-attribute=const',
         '-Wno-suggest-attribute=pure',
+        '-Wno-switch-default',
+        '-Wno-switch-enum',
         '-Wno-unsuffixed-float-constants',
         '-Wno-unused-const-variable',
+        '-Wno-unused-macros',
       ]
+    endif
 
-    elif cc.get_id() == 'msvc'
+    if warning_level in ['everything', '3', '2']
+      c_suppressions += [
+        '-Wno-unused-parameter',
+      ]
+    endif
+
+  elif cc.get_id() == 'msvc'
+    if warning_level == 'everything'
       c_suppressions += [
         '/wd4061', # enumerator in switch is not explicitly handled
         '/wd4090', # different const qualifiers
@@ -122,18 +129,45 @@ endif
 if is_variable('cpp')
   cpp_suppressions = []
 
-  if get_option('strict')
-    if cpp.get_id() == 'clang'
-      cpp_suppressions = clang_common_suppressions + [
-        '-Wno-extra-semi-stmt',
-        '-Wno-old-style-cast',
+  if cpp.get_id() == 'clang'
+    if warning_level == 'everything'
+      cpp_suppressions += [
+        '-Wno-c++98-compat-pedantic',
+        '-Wno-cast-align', # MacOS
+        '-Wno-cast-qual', # MacOS
+        '-Wno-documentation-unknown-command', # MacOS
+        '-Wno-double-promotion',
+        '-Wno-float-conversion',
+        '-Wno-implicit-float-conversion',
+        '-Wno-old-style-cast', # MacOS
+        '-Wno-padded',
+        '-Wno-redundant-parens',
+        '-Wno-reserved-id-macro', # MacOS
+        '-Wno-shorten-64-to-32',
+        '-Wno-sign-conversion',
         '-Wno-weak-vtables',
-        '-Wno-zero-as-null-pointer-constant',
+        '-Wno-zero-as-null-pointer-constant', # MacOS
       ]
 
-    elif cpp.get_id() == 'gcc'
-      cpp_suppressions = gcc_common_suppressions + [
+      if not meson.is_cross_build()
+        cpp_suppressions += [
+          '-Wno-poison-system-directories',
+        ]
+      endif
+    endif
+
+    if warning_level in ['everything', '3']
+      cpp_suppressions += [
+        '-Wno-nullability-extension',
+      ]
+    endif
+
+  elif cpp.get_id() == 'gcc'
+    if warning_level == 'everything'
+      cpp_suppressions += [
+        '-Wno-conversion',
         '-Wno-effc++',
+        '-Wno-padded',
         '-Wno-strict-overflow',
         '-Wno-suggest-attribute=const',
         '-Wno-suggest-attribute=pure',
diff --git a/meson/warnings/meson.build b/meson/warnings/meson.build
deleted file mode 100644
index cc13fc7..0000000
--- a/meson/warnings/meson.build
+++ /dev/null
@@ -1,238 +0,0 @@
-# Copyright 2020-2022 David Robillard <d@drobilla.net>
-# SPDX-License-Identifier: 0BSD OR ISC
-
-# General code to enable approximately all warnings in GCC 12, clang, and MSVC.
-#
-# This is trivial for clang and MSVC, but GCC doesn't have an "everything"
-# option, so we need to enable everything we want explicitly.  Wall is assumed,
-# but Wextra is not, for stability.
-#
-# These are collected from common.opt and c.opt in the GCC source, and manually
-# curated with the help of the GCC documentation.  Warnings that are
-# application-specific, historical, or about compatibility between specific
-# language revisions are omitted.  The intent here is to have roughly the same
-# meaning as clang's Weverything: extremely strict, but general.  Specifically
-# omitted are:
-#
-# General:
-#
-# Wabi=
-# Waggregate-return
-# Walloc-size-larger-than=BYTES
-# Walloca-larger-than=BYTES
-# Wframe-larger-than=BYTES
-# Wlarger-than=BYTES
-# Wstack-usage=BYTES
-# Wsystem-headers
-# Wtraditional
-# Wtraditional-conversion
-# Wtrampolines
-# Wvla-larger-than=BYTES
-#
-# Build specific:
-#
-# Wpoison-system-directories
-#
-# C Specific:
-#
-# Wc11-c2x-compat
-# Wc90-c99-compat
-# Wc99-c11-compat
-# Wdeclaration-after-statement
-# Wtraditional
-# Wtraditional-conversion
-#
-# C++ Specific:
-#
-# Wc++0x-compat
-# Wc++1z-compat
-# Wc++2a-compat
-# Wctad-maybe-unsupported
-# Wnamespaces
-# Wtemplates
-
-gcc_common_warnings = [
-  '-Walloc-zero',
-  '-Walloca',
-  '-Wanalyzer-too-complex',
-  '-Warith-conversion',
-  '-Warray-bounds=2',
-  '-Wattribute-alias=2',
-  '-Wbidi-chars=ucn',
-  '-Wcast-align=strict',
-  '-Wcast-function-type',
-  '-Wcast-qual',
-  '-Wclobbered',
-  '-Wconversion',
-  '-Wdate-time',
-  '-Wdisabled-optimization',
-  '-Wdouble-promotion',
-  '-Wduplicated-branches',
-  '-Wduplicated-cond',
-  '-Wempty-body',
-  '-Wendif-labels',
-  '-Wfloat-equal',
-  '-Wformat-overflow=2',
-  '-Wformat-signedness',
-  '-Wformat-truncation=2',
-  '-Wformat=2',
-  '-Wignored-qualifiers',
-  '-Wimplicit-fallthrough=3',
-  '-Winit-self',
-  '-Winline',
-  '-Winvalid-pch',
-  '-Wlogical-op',
-  '-Wmissing-declarations',
-  '-Wmissing-field-initializers',
-  '-Wmissing-include-dirs',
-  '-Wmultichar',
-  '-Wnormalized=nfc',
-  '-Wnull-dereference',
-  '-Wopenacc-parallelism',
-  '-Woverlength-strings',
-  '-Wpacked',
-  '-Wpacked-bitfield-compat',
-  '-Wpadded',
-  '-Wpointer-arith',
-  '-Wredundant-decls',
-  '-Wshadow',
-  '-Wshift-negative-value',
-  '-Wshift-overflow=2',
-  '-Wstack-protector',
-  '-Wstrict-aliasing=3',
-  '-Wstrict-overflow=5',
-  '-Wstring-compare',
-  '-Wstringop-overflow=3',
-  '-Wsuggest-attribute=cold',
-  '-Wsuggest-attribute=const',
-  '-Wsuggest-attribute=format',
-  '-Wsuggest-attribute=malloc',
-  '-Wsuggest-attribute=noreturn',
-  '-Wsuggest-attribute=pure',
-  '-Wswitch-default',
-  '-Wswitch-enum',
-  '-Wtrampolines',
-  '-Wtrivial-auto-var-init',
-  '-Wtype-limits',
-  '-Wundef',
-  '-Wuninitialized',
-  '-Wunsafe-loop-optimizations',
-  '-Wunused',
-  '-Wunused-const-variable=2',
-  '-Wunused-macros',
-  '-Wvector-operation-performance',
-  '-Wvla',
-  '-Wwrite-strings',
-]
-
-#####
-# C #
-#####
-
-if is_variable('cc') and not is_variable('all_c_warnings')
-  all_c_warnings = []
-
-  if cc.get_id() == 'clang'
-    all_c_warnings += ['-Weverything']
-
-    if not meson.is_cross_build()
-      all_c_warnings += [
-        '-Wno-poison-system-directories',
-      ]
-    endif
-
-  elif cc.get_id() == 'gcc'
-    all_c_warnings += gcc_common_warnings + [
-      '-Wabsolute-value',
-      '-Wbad-function-cast',
-      '-Wc++-compat',
-      '-Wenum-conversion',
-      '-Wjump-misses-init',
-      '-Wmissing-parameter-type',
-      '-Wmissing-prototypes',
-      '-Wnested-externs',
-      '-Wold-style-declaration',
-      '-Wold-style-definition',
-      '-Woverride-init',
-      '-Wsign-compare',
-      '-Wstrict-prototypes',
-      '-Wunsuffixed-float-constants',
-    ]
-
-  elif cc.get_id() == 'msvc'
-    all_c_warnings += ['/Wall']
-  endif
-
-  all_c_warnings = cc.get_supported_arguments(all_c_warnings)
-  add_global_arguments(all_c_warnings, language: ['c'])
-endif
-
-#######
-# C++ #
-#######
-
-if is_variable('cpp')
-  all_cpp_warnings = []
-
-  if cpp.get_id() == 'clang'
-    all_cpp_warnings += [
-      '-Weverything',
-      '-Wno-c++98-compat',
-      '-Wno-c++98-compat-pedantic'
-    ]
-
-    if not meson.is_cross_build()
-      all_cpp_warnings += [
-        '-Wno-poison-system-directories',
-      ]
-    endif
-
-  elif cpp.get_id() == 'gcc'
-    all_cpp_warnings += gcc_common_warnings + [
-      '-Wabi-tag',
-      '-Waligned-new=all',
-      '-Wcatch-value=3',
-      '-Wcomma-subscript',
-      '-Wconditionally-supported',
-      '-Wctor-dtor-privacy',
-      '-Wdelete-non-virtual-dtor',
-      '-Wdeprecated',
-      '-Wdeprecated-copy',
-      '-Wdeprecated-copy-dtor',
-      '-Wdeprecated-enum-enum-conversion',
-      '-Wdeprecated-enum-float-conversion',
-      '-Weffc++',
-      '-Wexpansion-to-defined',
-      '-Wextra-semi',
-      '-Wimport',
-      '-Winvalid-imported-macros',
-      '-Wmismatched-tags',
-      '-Wmultiple-inheritance',
-      '-Wnoexcept',
-      '-Wnoexcept-type',
-      '-Wnon-virtual-dtor',
-      '-Wold-style-cast',
-      '-Woverloaded-virtual',
-      '-Wplacement-new=2',
-      '-Wredundant-move',
-      '-Wredundant-tags',
-      '-Wregister',
-      '-Wsign-compare',
-      '-Wsign-promo',
-      '-Wsized-deallocation',
-      '-Wstrict-null-sentinel',
-      '-Wsuggest-final-methods',
-      '-Wsuggest-final-types',
-      '-Wsuggest-override',
-      '-Wuseless-cast',
-      '-Wvirtual-inheritance',
-      '-Wvolatile',
-      '-Wzero-as-null-pointer-constant',
-    ]
-
-  elif cpp.get_id() == 'msvc'
-    all_cpp_warnings += ['/Wall']
-  endif
-
-  all_cpp_warnings = cpp.get_supported_arguments(all_cpp_warnings)
-endif
diff --git a/meson_options.txt b/meson_options.txt
index d420bf2..77cc20d 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -1,5 +1,8 @@
-option('checks', type: 'boolean', value: true, yield: true,
-       description: 'Check for features with the build system')
+# Copyright 2020-2023 David Robillard <d@drobilla.net>
+# SPDX-License-Identifier: 0BSD OR ISC
+
+option('checks', type: 'feature', value: 'enabled', yield: true,
+       description: 'Check for platform-specific features')
 
 option('cxx', type: 'feature', value: 'auto', yield: true,
        description: 'Build C++ programs')
@@ -13,15 +16,15 @@ option('portaudio', type: 'feature', value: 'auto', yield: true,
 option('jack', type: 'feature', value: 'auto', yield: true,
        description: 'Build JACK driver')
 
+option('lint', type: 'boolean', value: false, yield: true,
+       description: 'Run code quality checks')
+
 option('posix', type: 'feature', value: 'auto', yield: true,
        description: 'Use POSIX system facilities')
 
 option('qt5', type: 'feature', value: 'auto', yield: true,
        description: 'Build Qt5 GUI')
 
-option('strict', type: 'boolean', value: false, yield: true,
-       description: 'Enable ultra-strict warnings')
-
 option('suil', type: 'feature', value: 'auto', yield: true,
        description: 'Use suil to load plugin UIs')
 
diff --git a/test/meson.build b/test/meson.build
index a4c4571..f26b819 100644
--- a/test/meson.build
+++ b/test/meson.build
@@ -1,7 +1,7 @@
 # Copyright 2019-2022 David Robillard <d@drobilla.net>
 # SPDX-License-Identifier: 0BSD OR ISC
 
-if get_option('strict')
+if get_option('lint')
   if not meson.is_subproject()
     # Check release metadata
     autoship = find_program('autoship', required: get_option('tests'))