Add assertions for all non-null pointers in the public API

Clang issues warnings at build time based on the SERD_NONNULL annotations,
which is a much better approach in general.  However, it does not cover cases
where the API is being used with another compiler, or without a compiler that
can statically check things at all (such as Python or other dynamic language
bindings).

In those situations, getting a clear assertion message is a lot less confusing
than a random crash somewhere in serd, and it makes it clear that the bug is in
the caller, so I think it's worth the tedious verbosity.

1 files changed, 7 insertions, 0 deletions

diff --git a/src/caret.c b/src/caret.c
index 2fe92f94..b6911468 100644
--- a/src/caret.c
+++ b/src/caret.c
@@ -16,6 +16,7 @@
 
 #include "caret.h"
 
+#include <assert.h>
 #include <stdbool.h>
 #include <stdlib.h>
 #include <string.h>
@@ -23,6 +24,8 @@
 SerdCaret*
 serd_caret_new(const SerdNode* name, unsigned line, unsigned col)
 {
+  assert(name);
+
   SerdCaret* caret = (SerdCaret*)malloc(sizeof(SerdCaret));
 
   caret->file = name;
@@ -59,17 +62,21 @@ serd_caret_equals(const SerdCaret* l, const SerdCaret* r)
 const SerdNode*
 serd_caret_name(const SerdCaret* caret)
 {
+  assert(caret);
+  assert(caret->file);
   return caret->file;
 }
 
 unsigned
 serd_caret_line(const SerdCaret* caret)
 {
+  assert(caret);
   return caret->line;
 }
 
 unsigned
 serd_caret_column(const SerdCaret* caret)
 {
+  assert(caret);
   return caret->col;
 }