aboutsummaryrefslogtreecommitdiffstats
path: root/src/filter.c
diff options
context:
space:
mode:
authorDavid Robillard <d@drobilla.net>2022-01-02 14:12:54 -0500
committerDavid Robillard <d@drobilla.net>2022-01-28 21:57:05 -0500
commit155fceabe7070b6610d577734734d038d097b088 (patch)
tree5bbbf327a00c2637f85f006c4b429ecc3b3cb1a3 /src/filter.c
parent1159aea45d9bc4ade2e82856be403d58e050f32d (diff)
downloadserd-155fceabe7070b6610d577734734d038d097b088.tar.gz
serd-155fceabe7070b6610d577734734d038d097b088.tar.bz2
serd-155fceabe7070b6610d577734734d038d097b088.zip
Add assertions for all non-null pointers in the public API
Clang issues warnings at build time based on the SERD_NONNULL annotations, which is a much better approach in general. However, it does not cover cases where the API is being used with another compiler, or without a compiler that can statically check things at all (such as Python or other dynamic language bindings). In those situations, getting a clear assertion message is a lot less confusing than a random crash somewhere in serd, and it makes it clear that the bug is in the caller, so I think it's worth the tedious verbosity.
Diffstat (limited to 'src/filter.c')
-rw-r--r--src/filter.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/filter.c b/src/filter.c
index 6d5e5a04..e5e8fa29 100644
--- a/src/filter.c
+++ b/src/filter.c
@@ -16,6 +16,7 @@
#include "serd/serd.h"
+#include <assert.h>
#include <stdbool.h>
#include <stdlib.h>
@@ -76,6 +77,8 @@ serd_filter_new(const SerdSink* const target,
const SerdNode* const graph,
const bool inclusive)
{
+ assert(target);
+
SerdFilterData* const data =
(SerdFilterData*)calloc(1, sizeof(SerdFilterData));