Add assertions for all non-null pointers in the public API

Clang issues warnings at build time based on the SERD_NONNULL annotations,
which is a much better approach in general.  However, it does not cover cases
where the API is being used with another compiler, or without a compiler that
can statically check things at all (such as Python or other dynamic language
bindings).

In those situations, getting a clear assertion message is a lot less confusing
than a random crash somewhere in serd, and it makes it clear that the bug is in
the caller, so I think it's worth the tedious verbosity.

1 files changed, 4 insertions, 0 deletions

diff --git a/src/nodes.c b/src/nodes.c
index a7d0ab2b..5c6492e4 100644
--- a/src/nodes.c
+++ b/src/nodes.c
@@ -225,6 +225,8 @@ serd_nodes_free(SerdNodes* nodes)
 size_t
 serd_nodes_size(const SerdNodes* nodes)
 {
+  assert(nodes);
+
   return zix_hash_size(nodes->hash);
 }
 
@@ -257,6 +259,8 @@ serd_nodes_intern(SerdNodes* nodes, const SerdNode* node)
 const SerdNode*
 serd_nodes_get(const SerdNodes* const nodes, const SerdNode* const node)
 {
+  assert(nodes);
+
   if (!node) {
     return NULL;
   }