Make Reader always read from a ByteSource

1 files changed, 30 insertions, 57 deletions

diff --git a/src/reader.c b/src/reader.c
index ed6caafd..fe88ee14 100644
--- a/src/reader.c
+++ b/src/reader.c
@@ -37,7 +37,7 @@ r_err(SerdReader* const reader, const SerdStatus st, const char* const fmt, ...)
 {
   va_list args;
   va_start(args, fmt);
-  const SerdError e = {st, &reader->source.caret, fmt, &args};
+  const SerdError e = {st, &reader->source->caret, fmt, &args};
   serd_world_error(reader->world, &e);
   va_end(args);
   return st;
@@ -69,7 +69,8 @@ tolerate_status(const SerdReader* const reader, const SerdStatus status)
   }
 
   if (status == SERD_ERR_INTERNAL || status == SERD_ERR_OVERFLOW ||
-      status == SERD_ERR_BAD_WRITE || status == SERD_ERR_NO_DATA) {
+      status == SERD_ERR_BAD_WRITE || status == SERD_ERR_NO_DATA ||
+      status == SERD_ERR_BAD_CALL) {
     return false;
   }
 
@@ -145,7 +146,7 @@ emit_statement(SerdReader* const reader,
   serd_node_zero_pad(o);
 
   const SerdStatement statement = {{ctx.subject, ctx.predicate, o, ctx.graph},
-                                   &reader->source.caret};
+                                   &reader->source->caret};
 
   const SerdStatus st =
     serd_sink_write_statement(reader->sink, *ctx.flags, &statement);
@@ -163,7 +164,11 @@ read_statement(SerdReader* const reader)
 SerdStatus
 serd_reader_read_document(SerdReader* const reader)
 {
-  if (!reader->source.prepared) {
+  if (!reader->source) {
+    return SERD_ERR_BAD_CALL;
+  }
+
+  if (!reader->source->prepared) {
     SerdStatus st = serd_reader_prepare(reader);
     if (st) {
       return st;
@@ -241,12 +246,12 @@ serd_reader_add_blank_prefix(SerdReader* const reader, const char* const prefix)
 static SerdStatus
 skip_bom(SerdReader* const me)
 {
-  if (serd_byte_source_peek(&me->source) == 0xEF) {
-    serd_byte_source_advance(&me->source);
-    if (serd_byte_source_peek(&me->source) != 0xBB ||
-        serd_byte_source_advance(&me->source) ||
-        serd_byte_source_peek(&me->source) != 0xBF ||
-        serd_byte_source_advance(&me->source)) {
+  if (serd_byte_source_peek(me->source) == 0xEF) {
+    serd_byte_source_advance(me->source);
+    if (serd_byte_source_peek(me->source) != 0xBB ||
+        serd_byte_source_advance(me->source) ||
+        serd_byte_source_peek(me->source) != 0xBF ||
+        serd_byte_source_advance(me->source)) {
       r_err(me, SERD_ERR_BAD_SYNTAX, "corrupt byte order mark\n");
       return SERD_ERR_BAD_SYNTAX;
     }
@@ -256,60 +261,23 @@ skip_bom(SerdReader* const me)
 }
 
 SerdStatus
-serd_reader_start_stream(SerdReader* const         reader,
-                         const SerdReadFunc        read_func,
-                         const SerdStreamErrorFunc error_func,
-                         void* const               stream,
-                         const SerdNode* const     name,
-                         const size_t              page_size)
+serd_reader_start(SerdReader* const reader, SerdByteSource* const byte_source)
 {
-  return serd_byte_source_open_source(
-    &reader->source, read_func, error_func, NULL, stream, name, page_size);
-}
-
-SerdStatus
-serd_reader_start_file(SerdReader* reader, const char* uri, bool bulk)
-{
-  char* const path = serd_parse_file_uri(uri, NULL);
-  if (!path) {
-    return SERD_ERR_BAD_ARG;
-  }
-
-  FILE* fd = serd_world_fopen(reader->world, path, "rb");
-  free(path);
-  if (!fd) {
-    return SERD_ERR_UNKNOWN;
-  }
+  serd_reader_finish(reader);
 
-  SerdNode* const  name = serd_new_uri(SERD_STRING(uri));
-  const SerdStatus st   = serd_byte_source_open_source(
-    &reader->source,
-    bulk ? (SerdReadFunc)fread : serd_file_read_byte,
-    (SerdStreamErrorFunc)ferror,
-    (SerdStreamCloseFunc)fclose,
-    fd,
-    name,
-    bulk ? SERD_PAGE_SIZE : 1u);
-  serd_node_free(name);
-  return st;
-}
+  reader->source = byte_source;
 
-SerdStatus
-serd_reader_start_string(SerdReader* const     reader,
-                         const char* const     utf8,
-                         const SerdNode* const name)
-{
-  return serd_byte_source_open_string(&reader->source, utf8, name);
+  return reader->source ? SERD_SUCCESS : SERD_ERR_BAD_ARG;
 }
 
 static SerdStatus
 serd_reader_prepare(SerdReader* const reader)
 {
-  SerdStatus st = serd_byte_source_prepare(&reader->source);
+  SerdStatus st = serd_byte_source_prepare(reader->source);
   if (st == SERD_SUCCESS) {
     st = skip_bom(reader);
   } else if (st == SERD_FAILURE) {
-    reader->source.eof = true;
+    reader->source->eof = true;
   }
   return st;
 }
@@ -318,10 +286,14 @@ SerdStatus
 serd_reader_read_chunk(SerdReader* const reader)
 {
   SerdStatus st = SERD_SUCCESS;
-  if (!reader->source.prepared) {
+  if (!reader->source) {
+    return SERD_ERR_BAD_CALL;
+  }
+
+  if (!reader->source->prepared) {
     st = serd_reader_prepare(reader);
-  } else if (reader->source.eof) {
-    st = serd_byte_source_advance(&reader->source);
+  } else if (reader->source->eof) {
+    st = serd_byte_source_advance(reader->source);
   }
 
   return st ? st : read_statement(reader);
@@ -330,5 +302,6 @@ serd_reader_read_chunk(SerdReader* const reader)
 SerdStatus
 serd_reader_finish(SerdReader* const reader)
 {
-  return serd_byte_source_close(&reader->source);
+  reader->source = NULL;
+  return SERD_SUCCESS;
 }