Add assertions for all non-null pointers in the public API

Clang issues warnings at build time based on the SERD_NONNULL annotations,
which is a much better approach in general.  However, it does not cover cases
where the API is being used with another compiler, or without a compiler that
can statically check things at all (such as Python or other dynamic language
bindings).

In those situations, getting a clear assertion message is a lot less confusing
than a random crash somewhere in serd, and it makes it clear that the bug is in
the caller, so I think it's worth the tedious verbosity.

1 files changed, 10 insertions, 0 deletions

diff --git a/src/uri.c b/src/uri.c
index c66e28d7..1862c280 100644
--- a/src/uri.c
+++ b/src/uri.c
@@ -19,6 +19,7 @@
 
 #include "serd/serd.h"
 
+#include <assert.h>
 #include <stdbool.h>
 #include <stdio.h>
 #include <stdlib.h>
@@ -27,6 +28,8 @@
 char*
 serd_parse_file_uri(const char* const uri, char** const hostname)
 {
+  assert(uri);
+
   const char* path = uri;
   if (hostname) {
     *hostname = NULL;
@@ -79,6 +82,8 @@ serd_parse_file_uri(const char* const uri, char** const hostname)
 bool
 serd_uri_string_has_scheme(const char* const string)
 {
+  assert(string);
+
   if (is_alpha(string[0])) {
     for (size_t i = 1; string[i]; ++i) {
       if (!is_uri_scheme_char(string[i])) {
@@ -97,6 +102,8 @@ serd_uri_string_has_scheme(const char* const string)
 SerdURIView
 serd_parse_uri(const char* const string)
 {
+  assert(string);
+
   SerdURIView result = SERD_URI_NULL;
   const char* ptr    = string;
 
@@ -453,6 +460,9 @@ serd_write_uri(const SerdURIView   uri,
                const SerdWriteFunc sink,
                void* const         stream)
 {
+  assert(sink);
+  assert(stream);
+
   size_t len = 0;
 
   if (uri.scheme.buf) {