Replace strict option with new meson warning level

6 files changed, 113 insertions, 271 deletions

diff --git a/meson.build b/meson.build
index c8151fe..115994e 100644
--- a/meson.build
+++ b/meson.build
@@ -32,9 +32,6 @@ if not get_option('bindings_cpp').disabled()
 endif
 
 # Set global warning flags
-if get_option('strict') and not meson.is_subproject()
-  subdir('meson/warnings')
-endif
 subdir('meson/suppressions')
 
 ##########################
diff --git a/meson/suppressions/meson.build b/meson/suppressions/meson.build
index 8785c56..7888e8d 100644
--- a/meson/suppressions/meson.build
+++ b/meson/suppressions/meson.build
@@ -1,112 +1,134 @@
-# Copyright 2020-2022 David Robillard <d@drobilla.net>
+# Copyright 2020-2023 David Robillard <d@drobilla.net>
 # SPDX-License-Identifier: 0BSD OR ISC
 
-# Project-specific warning suppressions.
-#
-# This should be used in conjunction with the generic "warnings" sibling that
-# enables all reasonable warnings for the compiler.  It lives here just to keep
-# the top-level meson.build more readable.
+# Project-specific warning suppressions
+
+warning_level = get_option('warning_level')
 
 #####
 # C #
 #####
 
-if is_variable('cc')
-  c_suppressions = []
+c_suppressions = []
 
-  if get_option('strict')
-    if cc.get_id() == 'clang'
-      c_suppressions += [
-        '-Wno-cast-align',
-        '-Wno-cast-qual',
-        '-Wno-declaration-after-statement',
-        '-Wno-documentation-unknown-command',
-        '-Wno-double-promotion',
-        '-Wno-float-equal',
-        '-Wno-format-nonliteral',
-        '-Wno-implicit-float-conversion',
-        '-Wno-implicit-int-conversion',
-        '-Wno-nullability-extension',
-        '-Wno-nullable-to-nonnull-conversion',
-        '-Wno-padded',
-        '-Wno-reserved-id-macro',
-        '-Wno-shorten-64-to-32',
-        '-Wno-sign-conversion',
-        '-Wno-switch-enum',
-        '-Wno-vla',
-      ]
+if cc.get_id() in ['clang', 'emscripten']
+  if warning_level == 'everything'
+    c_suppressions += [
+      '-Wno-cast-align',
+      '-Wno-cast-qual',
+      '-Wno-declaration-after-statement',
+      '-Wno-documentation-unknown-command',
+      '-Wno-double-promotion',
+      '-Wno-float-equal',
+      '-Wno-format-nonliteral',
+      '-Wno-implicit-float-conversion',
+      '-Wno-implicit-int-conversion',
+      '-Wno-nullable-to-nonnull-conversion',
+      '-Wno-padded',
+      '-Wno-reserved-id-macro',
+      '-Wno-shorten-64-to-32',
+      '-Wno-sign-conversion',
+      '-Wno-switch-enum',
+      '-Wno-vla',
+    ]
+  endif
 
-      if host_machine.system() == 'darwin'
-        c_suppressions += [
-          '-Wno-unused-macros',
-        ]
-      elif host_machine.system() == 'freebsd'
-        c_suppressions += [
-          '-Wno-c11-extensions',
-        ]
-      elif host_machine.system() == 'windows'
-        c_suppressions += [
-          '-Wno-deprecated-declarations',
-          '-Wno-nonportable-system-include-path',
-          '-Wno-unused-macros',
-        ]
-      endif
+  if warning_level in ['everything', '3']
+    c_suppressions += [
+      '-Wno-nullability-extension',
+    ]
 
-    elif cc.get_id() == 'gcc'
+    if host_machine.system() == 'freebsd'
       c_suppressions += [
-        '-Wno-cast-align',
-        '-Wno-cast-qual',
-        '-Wno-conversion',
-        '-Wno-double-promotion',
-        '-Wno-float-equal',
-        '-Wno-format-nonliteral',
-        '-Wno-format-truncation',
-        '-Wno-inline',
-        '-Wno-padded',
-        '-Wno-stack-protector',
-        '-Wno-strict-overflow',
-        '-Wno-suggest-attribute=const',
-        '-Wno-suggest-attribute=pure',
-        '-Wno-switch-default',
-        '-Wno-switch-enum',
-        '-Wno-unsuffixed-float-constants',
-        '-Wno-unused-const-variable',
-        '-Wno-unused-parameter',
-        '-Wno-vla',
+        '-Wno-c11-extensions',
       ]
-
-      if host_machine.system() == 'windows'
-        c_suppressions += [
-          '-Wno-bad-function-cast',
-          '-Wno-unused-macros',
-        ]
-      endif
-
-    elif cc.get_id() == 'msvc'
+    elif host_machine.system() == 'darwin'
+      c_suppressions += [
+        '-Wno-unused-macros',
+      ]
+    elif host_machine.system() == 'windows'
       c_suppressions += [
-        '/wd4061', # enumerator in switch is not explicitly handled
-        '/wd4191', # unsafe conversion from FARPROC
-        '/wd4244', # conversion from floating point, possible loss of data
-        '/wd4267', # conversion from size_t, possible loss of data
-        '/wd4365', # signed/unsigned mismatch
-        '/wd4514', # unreferenced inline function has been removed
-        '/wd4706', # assignment within conditional expression
-        '/wd4710', # function not inlined
-        '/wd4711', # function selected for automatic inline expansion
-        '/wd4774', # format string is not a string literal
-        '/wd4800', # implicit conversion to bool
-        '/wd4820', # padding added after construct
-        '/wd4996', # POSIX name for this item is deprecated
-        '/wd5045', # will insert Spectre mitigation for memory load
+        '-Wno-deprecated-declarations',
+        '-Wno-nonportable-system-include-path',
+        '-Wno-unused-macros',
       ]
     endif
   endif
 
-  if cc.get_id() == 'msvc'
+elif cc.get_id() == 'gcc'
+  if warning_level == 'everything'
+    c_suppressions += [
+      '-Wno-cast-align',
+      '-Wno-cast-qual',
+      '-Wno-conversion',
+      '-Wno-double-promotion',
+      '-Wno-float-equal',
+      '-Wno-format-nonliteral',
+      '-Wno-format-truncation',
+      '-Wno-inline',
+      '-Wno-padded',
+      '-Wno-stack-protector',
+      '-Wno-strict-overflow',
+      '-Wno-suggest-attribute=const',
+      '-Wno-suggest-attribute=pure',
+      '-Wno-switch-default',
+      '-Wno-switch-enum',
+      '-Wno-unsuffixed-float-constants',
+      '-Wno-unused-const-variable',
+      '-Wno-unused-parameter',
+      '-Wno-vla',
+    ]
+  endif
+
+  if warning_level in ['everything', '3']
+    c_suppressions += [
+      '-Wno-pedantic',
+    ]
+  endif
+
+  if host_machine.system() == 'windows'
+    c_suppressions += [
+      '-Wno-bad-function-cast',
+      '-Wno-unused-macros',
+    ]
+  endif
+
+elif cc.get_id() == 'msvc'
+  c_suppressions += [
+    '/experimental:external',
+    '/external:W0',
+    '/external:anglebrackets',
+  ]
+
+  if warning_level == 'everything'
+    c_suppressions += [
+      '/wd4061', # enumerator in switch is not explicitly handled
+      '/wd4191', # unsafe conversion from FARPROC
+      '/wd4365', # signed/unsigned mismatch
+      '/wd4514', # unreferenced inline function has been removed
+      '/wd4710', # function not inlined
+      '/wd4711', # function selected for automatic inline expansion
+      '/wd4774', # format string is not a string literal
+      '/wd4800', # implicit conversion to bool
+      '/wd4820', # padding added after construct
+      '/wd5045', # will insert Spectre mitigation for memory load
+    ]
+  endif
+
+  if warning_level in ['everything', '3']
     c_suppressions += [
       '/wd4090', # different const qualifiers
+      '/wd4706', # assignment within conditional expression
     ]
   endif
 
-  c_suppressions = cc.get_supported_arguments(c_suppressions)
+  if warning_level in ['everything', '3', '2']
+    c_suppressions += [
+      '/wd4244', # conversion from floating point, possible loss of data
+      '/wd4267', # conversion from size_t, possible loss of data
+      '/wd4996', # POSIX name for this item is deprecated
+    ]
+  endif
 endif
+
+c_suppressions = cc.get_supported_arguments(c_suppressions)
diff --git a/meson/warnings/meson.build b/meson/warnings/meson.build
deleted file mode 100644
index 80d5774..0000000
--- a/meson/warnings/meson.build
+++ /dev/null
@@ -1,175 +0,0 @@
-# Copyright 2020-2022 David Robillard <d@drobilla.net>
-# SPDX-License-Identifier: 0BSD OR ISC
-
-# General code to enable approximately all warnings in GCC 12, clang, and MSVC.
-#
-# This is trivial for clang and MSVC, but GCC doesn't have an "everything"
-# option, so we need to enable everything we want explicitly.  Wall is assumed,
-# but Wextra is not, for stability.
-#
-# These are collected from common.opt and c.opt in the GCC source, and manually
-# curated with the help of the GCC documentation.  Warnings that are
-# application-specific, historical, or about compatibility between specific
-# language revisions are omitted.  The intent here is to have roughly the same
-# meaning as clang's Weverything: extremely strict, but general.  Specifically
-# omitted are:
-#
-# General:
-#
-# Wabi=
-# Waggregate-return
-# Walloc-size-larger-than=BYTES
-# Walloca-larger-than=BYTES
-# Wframe-larger-than=BYTES
-# Wlarger-than=BYTES
-# Wstack-usage=BYTES
-# Wsystem-headers
-# Wtraditional
-# Wtraditional-conversion
-# Wtrampolines
-# Wvla-larger-than=BYTES
-#
-# Build specific:
-#
-# Wpoison-system-directories
-#
-# C Specific:
-#
-# Wc11-c2x-compat
-# Wc90-c99-compat
-# Wc99-c11-compat
-# Wdeclaration-after-statement
-# Wtraditional
-# Wtraditional-conversion
-#
-# C++ Specific:
-#
-# Wc++0x-compat
-# Wc++1z-compat
-# Wc++2a-compat
-# Wctad-maybe-unsupported
-# Wnamespaces
-# Wtemplates
-
-# GCC warnings that apply to all C-family languages
-gcc_common_warnings = [
-  '-Walloc-zero',
-  '-Walloca',
-  '-Wanalyzer-too-complex',
-  '-Warith-conversion',
-  '-Warray-bounds=2',
-  '-Wattribute-alias=2',
-  '-Wbidi-chars=ucn',
-  '-Wcast-align=strict',
-  '-Wcast-function-type',
-  '-Wcast-qual',
-  '-Wclobbered',
-  '-Wconversion',
-  '-Wdate-time',
-  '-Wdisabled-optimization',
-  '-Wdouble-promotion',
-  '-Wduplicated-branches',
-  '-Wduplicated-cond',
-  '-Wempty-body',
-  '-Wendif-labels',
-  '-Wfloat-equal',
-  '-Wformat-overflow=2',
-  '-Wformat-signedness',
-  '-Wformat-truncation=2',
-  '-Wformat=2',
-  '-Wignored-qualifiers',
-  '-Wimplicit-fallthrough=3',
-  '-Winit-self',
-  '-Winline',
-  '-Winvalid-pch',
-  '-Wlogical-op',
-  '-Wmissing-declarations',
-  '-Wmissing-field-initializers',
-  '-Wmissing-include-dirs',
-  '-Wmultichar',
-  '-Wnormalized=nfc',
-  '-Wnull-dereference',
-  '-Wopenacc-parallelism',
-  '-Woverlength-strings',
-  '-Wpacked',
-  '-Wpacked-bitfield-compat',
-  '-Wpadded',
-  '-Wpointer-arith',
-  '-Wredundant-decls',
-  '-Wshadow',
-  '-Wshift-negative-value',
-  '-Wshift-overflow=2',
-  '-Wstack-protector',
-  '-Wstrict-aliasing=3',
-  '-Wstrict-overflow=5',
-  '-Wstring-compare',
-  '-Wstringop-overflow=3',
-  '-Wsuggest-attribute=cold',
-  '-Wsuggest-attribute=const',
-  '-Wsuggest-attribute=format',
-  '-Wsuggest-attribute=malloc',
-  '-Wsuggest-attribute=noreturn',
-  '-Wsuggest-attribute=pure',
-  '-Wswitch-default',
-  '-Wswitch-enum',
-  '-Wtrampolines',
-  '-Wtrivial-auto-var-init',
-  '-Wtype-limits',
-  '-Wundef',
-  '-Wuninitialized',
-  '-Wunsafe-loop-optimizations',
-  '-Wunused',
-  '-Wunused-const-variable=2',
-  '-Wunused-macros',
-  '-Wvector-operation-performance',
-  '-Wvla',
-  '-Wwrite-strings',
-]
-
-#####
-# C #
-#####
-
-if is_variable('cc')
-  # Set all_c_warnings for the current C compiler
-  all_c_warnings = []
-
-  if cc.get_id() == 'clang'
-    all_c_warnings += ['-Weverything']
-
-    if not meson.is_cross_build()
-      all_c_warnings += [
-        '-Wno-poison-system-directories',
-      ]
-    endif
-
-  elif cc.get_id() == 'gcc'
-    all_c_warnings += gcc_common_warnings + [
-      '-Wabsolute-value',
-      '-Wbad-function-cast',
-      '-Wc++-compat',
-      '-Wenum-conversion',
-      '-Wjump-misses-init',
-      '-Wmissing-parameter-type',
-      '-Wmissing-prototypes',
-      '-Wnested-externs',
-      '-Wold-style-declaration',
-      '-Wold-style-definition',
-      '-Woverride-init',
-      '-Wsign-compare',
-      '-Wstrict-prototypes',
-      '-Wunsuffixed-float-constants',
-    ]
-
-  elif cc.get_id() == 'msvc'
-    all_c_warnings += [
-      '/Wall',
-      '/experimental:external',
-      '/external:W0',
-      '/external:anglebrackets',
-    ]
-  endif
-
-  all_c_warnings = cc.get_supported_arguments(all_c_warnings)
-  add_global_arguments(all_c_warnings, language: ['c'])
-endif
diff --git a/meson_options.txt b/meson_options.txt
index 41de10f..b71c99d 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -13,9 +13,6 @@ option('default_lv2_path', type: 'string', value: '', yield: true,
 option('docs', type: 'feature', value: 'auto', yield: true,
        description: 'Build documentation')
 
-option('strict', type: 'boolean', value: false, yield: true,
-       description: 'Enable ultra-strict warnings')
-
 option('tests', type: 'feature', value: 'auto', yield: true,
        description: 'Build tests')
 
diff --git a/test/cpp/meson.build b/test/cpp/meson.build
index 4389d18..f062e63 100644
--- a/test/cpp/meson.build
+++ b/test/cpp/meson.build
@@ -10,6 +10,7 @@ if cpp.get_id() == 'gcc'
   ]
 elif cpp.get_id() == 'clang'
   cpp_suppressions += [
+    '-Wno-c++98-compat',
     '-Wno-cast-align',
     '-Wno-cast-qual',
     '-Wno-documentation-unknown-command',
diff --git a/test/meson.build b/test/meson.build
index e974951..06075b2 100644
--- a/test/meson.build
+++ b/test/meson.build
@@ -5,7 +5,7 @@
 # Project Metadata #
 ####################
 
-if get_option('strict')
+if get_option('warning_level') == 'everything'
   # Check release metadata
   if not meson.is_subproject()
     autoship = find_program('autoship', required: false)