summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Robillard <d@drobilla.net>2024-07-17 09:14:33 -0400
committerDavid Robillard <d@drobilla.net>2024-07-17 09:32:28 -0400
commit96aa54674cec5a55e31bd588448804d0f6dcdbfd (patch)
tree58cfcba6e9f0a1c6437517ecd5249f1b222fe978
parent4e14f1dd771cdaa430f1463ca9f59c3270edc22b (diff)
downloadpatchage-96aa54674cec5a55e31bd588448804d0f6dcdbfd.tar.gz
patchage-96aa54674cec5a55e31bd588448804d0f6dcdbfd.tar.bz2
patchage-96aa54674cec5a55e31bd588448804d0f6dcdbfd.zip
Make member function static
-rw-r--r--.clang-tidy1
-rw-r--r--src/JackLibDriver.cpp4
-rw-r--r--src/Patchage.cpp2
-rw-r--r--src/Patchage.hpp2
4 files changed, 4 insertions, 5 deletions
diff --git a/.clang-tidy b/.clang-tidy
index 6d42429..6276162 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -46,7 +46,6 @@ Checks: >
-modernize-use-nodiscard,
-modernize-use-trailing-return-type,
-performance-enum-size,
- -readability-convert-member-functions-to-static,
-readability-function-cognitive-complexity,
-readability-identifier-length,
-readability-implicit-bool-conversion,
diff --git a/src/JackLibDriver.cpp b/src/JackLibDriver.cpp
index 411916f..017abf5 100644
--- a/src/JackLibDriver.cpp
+++ b/src/JackLibDriver.cpp
@@ -74,8 +74,8 @@ public:
uint32_t sample_rate() override;
private:
- ClientInfo get_client_info(const char* name);
- PortInfo get_port_info(const jack_port_t* port);
+ static ClientInfo get_client_info(const char* name);
+ PortInfo get_port_info(const jack_port_t* port);
static void on_client(const char* name, int registered, void* driver);
diff --git a/src/Patchage.cpp b/src/Patchage.cpp
index 0a0de82..82c12df 100644
--- a/src/Patchage.cpp
+++ b/src/Patchage.cpp
@@ -305,7 +305,7 @@ Patchage::Patchage(Options options)
_main_scrolledwin->property_vadjustment().get_value()->set_step_increment(10);
_main_scrolledwin->signal_scroll_event().connect(
- sigc::mem_fun(this, &Patchage::on_scroll));
+ sigc::ptr_fun(&Patchage::on_scroll));
_clear_load_but->signal_clicked().connect(
sigc::mem_fun(this, &Patchage::clear_load));
_buf_size_combo->signal_changed().connect(
diff --git a/src/Patchage.hpp b/src/Patchage.hpp
index 8f3cca0..720a57c 100644
--- a/src/Patchage.hpp
+++ b/src/Patchage.hpp
@@ -126,7 +126,7 @@ protected:
void on_messages_resized(Gtk::Allocation& alloc);
- bool on_scroll(GdkEventScroll* ev);
+ static bool on_scroll(GdkEventScroll* ev);
void on_menu_action(const Action& action);