aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Robillard <d@drobilla.net>2023-01-10 21:38:01 -0500
committerDavid Robillard <d@drobilla.net>2023-01-11 03:28:10 -0500
commitc33edc9b41ccdd7ec3fe711d3a96002b266106bd (patch)
tree1735147be5b4f35500cde3c84f7a436cb6df4ec6
parent16739fe3b2cf0fe8c2ffcb3e983ef09aa04517dc (diff)
downloadpugl-c33edc9b41ccdd7ec3fe711d3a96002b266106bd.tar.gz
pugl-c33edc9b41ccdd7ec3fe711d3a96002b266106bd.tar.bz2
pugl-c33edc9b41ccdd7ec3fe711d3a96002b266106bd.zip
Fix checks for invalid view positions
-rw-r--r--src/mac.m2
-rw-r--r--src/win.c2
-rw-r--r--src/x11.c2
3 files changed, 3 insertions, 3 deletions
diff --git a/src/mac.m b/src/mac.m
index 77c825f..7b4e3a2 100644
--- a/src/mac.m
+++ b/src/mac.m
@@ -1718,7 +1718,7 @@ puglSetFrame(PuglView* view, const PuglRect frame)
PuglStatus
puglSetPosition(PuglView* const view, const int x, const int y)
{
- if (x > INT16_MAX || y > INT16_MAX) {
+ if (x < INT16_MIN || x > INT16_MAX || y < INT16_MIN || y > INT16_MAX) {
return PUGL_BAD_PARAMETER;
}
diff --git a/src/win.c b/src/win.c
index 4c4c815..d8c574b 100644
--- a/src/win.c
+++ b/src/win.c
@@ -1222,7 +1222,7 @@ puglSetFrame(PuglView* view, const PuglRect frame)
PuglStatus
puglSetPosition(PuglView* const view, const int x, const int y)
{
- if (x > INT16_MAX || y > INT16_MAX) {
+ if (x < INT16_MIN || x > INT16_MAX || y < INT16_MIN || y > INT16_MAX) {
return PUGL_BAD_PARAMETER;
}
diff --git a/src/x11.c b/src/x11.c
index ff7996a..f1a077b 100644
--- a/src/x11.c
+++ b/src/x11.c
@@ -1845,7 +1845,7 @@ puglSetPosition(PuglView* const view, const int x, const int y)
Display* const display = view->world->impl->display;
const Window win = view->impl->win;
- if (x > INT16_MAX || y > INT16_MAX) {
+ if (x < INT16_MIN || x > INT16_MAX || y < INT16_MIN || y > INT16_MAX) {
return PUGL_BAD_PARAMETER;
}