diff options
author | David Robillard <d@drobilla.net> | 2024-11-15 18:45:41 -0500 |
---|---|---|
committer | David Robillard <d@drobilla.net> | 2024-11-24 19:00:24 -0500 |
commit | 63f013dd2492f6c01792198aceb6874ccf227086 (patch) | |
tree | 84118463c70a8d00c57da1f0437b25818215c6e0 | |
parent | 317342083e79672e8803569c07756415fab44db5 (diff) | |
download | jalv-63f013dd2492f6c01792198aceb6874ccf227086.tar.gz jalv-63f013dd2492f6c01792198aceb6874ccf227086.tar.bz2 jalv-63f013dd2492f6c01792198aceb6874ccf227086.zip |
Remove transport position dumping from Jack process callback
This is handy at times, but prints in the process callback which is obviously
not realtime safe. The communication dumping is, though, and both are
controlled by the same option, so there wasn't a way to enable that without
introducing a pretty severe performance issue in the audio thread.
So, simply remove it for now. If transport dumping is really needed, it can be
implemented by sending the information to the main thread for printing there,
which will be easier after the upcoming work to improve the communication
facilities.
-rw-r--r-- | NEWS | 3 | ||||
-rw-r--r-- | src/jack.c | 2 |
2 files changed, 2 insertions, 3 deletions
@@ -11,13 +11,14 @@ jalv (1.6.9) unstable; urgency=medium * Fix minor memory leaks * Reduce Jack process callback overhead * Remove Gtk2 interface + * Remove transport position dumping from Jack process callback * Replace use of deprecated Gtk interfaces * Switch to external zix dependency * Use Gtk switches instead of checkboxes for toggle controls * Use fewer platform-specific APIs * Use portable zix filesystem API - -- David Robillard <d@drobilla.net> Fri, 15 Nov 2024 23:44:39 +0000 + -- David Robillard <d@drobilla.net> Fri, 15 Nov 2024 23:44:55 +0000 jalv (1.6.8) stable; urgency=medium @@ -121,8 +121,6 @@ jack_process_cb(jack_nframes_t nframes, void* data) lv2_atom_forge_key(forge, jalv->urids.time_beatsPerMinute); lv2_atom_forge_float(forge, pos.beats_per_minute); } - - jalv_dump_atom(jalv, stdout, "Position", lv2_pos, 32); } // Update transport state to expected values for next cycle |