summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Robillard <d@drobilla.net>2024-07-17 09:14:34 -0400
committerDavid Robillard <d@drobilla.net>2024-07-17 09:38:43 -0400
commite218739bbb66c9a4d2d8860a3322f2eb91b6c32e (patch)
treeb52c80580bd96eb8e86200dbe903c0477f0c3ec3
parent96aa54674cec5a55e31bd588448804d0f6dcdbfd (diff)
downloadpatchage-e218739bbb66c9a4d2d8860a3322f2eb91b6c32e.tar.gz
patchage-e218739bbb66c9a4d2d8860a3322f2eb91b6c32e.tar.bz2
patchage-e218739bbb66c9a4d2d8860a3322f2eb91b6c32e.zip
Avoid C-style casts
-rw-r--r--.clang-tidy2
-rw-r--r--src/ClientID.hpp2
-rw-r--r--src/JackDbusDriver.cpp2
-rw-r--r--src/JackLibDriver.cpp6
-rw-r--r--src/PortID.hpp5
5 files changed, 10 insertions, 7 deletions
diff --git a/.clang-tidy b/.clang-tidy
index 6276162..094d8d1 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -28,14 +28,12 @@ Checks: >
-cppcoreguidelines-pro-bounds-constant-array-index,
-cppcoreguidelines-pro-bounds-pointer-arithmetic,
-cppcoreguidelines-pro-type-const-cast,
- -cppcoreguidelines-pro-type-cstyle-cast,
-cppcoreguidelines-pro-type-reinterpret-cast,
-cppcoreguidelines-pro-type-union-access,
-fuchsia-default-arguments-calls,
-fuchsia-default-arguments-declarations,
-fuchsia-multiple-inheritance,
-fuchsia-overloaded-operator,
- -google-readability-casting,
-google-readability-todo,
-google-runtime-references,
-hicpp-no-array-decay,
diff --git a/src/ClientID.hpp b/src/ClientID.hpp
index f918ea4..dbe5b75 100644
--- a/src/ClientID.hpp
+++ b/src/ClientID.hpp
@@ -72,7 +72,7 @@ operator<<(std::ostream& os, const ClientID& id)
case ClientID::Type::jack:
return os << "jack:" << id.jack_name();
case ClientID::Type::alsa:
- return os << "alsa:" << int(id.alsa_id());
+ return os << "alsa:" << static_cast<int>(id.alsa_id());
}
assert(false);
diff --git a/src/JackDbusDriver.cpp b/src/JackDbusDriver.cpp
index e7e6830..f84cb51 100644
--- a/src/JackDbusDriver.cpp
+++ b/src/JackDbusDriver.cpp
@@ -937,7 +937,7 @@ JackDriver::port_info(const std::string& port_name,
patchage_port_type(port_type),
direction,
{},
- bool(port_flags & port_flag_terminal)};
+ static_cast<bool>(port_flags & port_flag_terminal)};
}
void
diff --git a/src/JackLibDriver.cpp b/src/JackLibDriver.cpp
index 017abf5..6df5b02 100644
--- a/src/JackLibDriver.cpp
+++ b/src/JackLibDriver.cpp
@@ -237,7 +237,11 @@ JackLibDriver::get_port_info(const jack_port_t* const port)
order = std::stoi(order_str);
}
- return {label, type, direction, order, bool(flags & JackPortIsTerminal)};
+ return {label,
+ type,
+ direction,
+ order,
+ static_cast<bool>(flags & JackPortIsTerminal)};
}
void
diff --git a/src/PortID.hpp b/src/PortID.hpp
index 54e4c5d..e22e670 100644
--- a/src/PortID.hpp
+++ b/src/PortID.hpp
@@ -108,8 +108,9 @@ operator<<(std::ostream& os, const PortID& id)
case PortID::Type::jack:
return os << "jack:" << id.jack_name();
case PortID::Type::alsa:
- return os << "alsa:" << int(id.alsa_client()) << ":" << int(id.alsa_port())
- << ":" << (id.alsa_is_input() ? "in" : "out");
+ return os << "alsa:" << static_cast<int>(id.alsa_client()) << ":"
+ << static_cast<int>(id.alsa_port()) << ":"
+ << (id.alsa_is_input() ? "in" : "out");
}
assert(false);