aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Robillard <d@drobilla.net>2022-10-23 21:48:47 -0400
committerDavid Robillard <d@drobilla.net>2022-10-23 21:48:47 -0400
commit5947cac55a98140859b7a5e7de357a1d45bccd43 (patch)
tree44f4ca4764b76fbec32987744bd93aec3b7322f6
parent57a6d0efb771801a9d91f817cc283a4994610197 (diff)
downloadserd-5947cac55a98140859b7a5e7de357a1d45bccd43.tar.gz
serd-5947cac55a98140859b7a5e7de357a1d45bccd43.tar.bz2
serd-5947cac55a98140859b7a5e7de357a1d45bccd43.zip
Fix "suspicious" string comparison
This is beyond silly.
-rw-r--r--src/.clang-tidy1
-rw-r--r--src/uri.c2
2 files changed, 1 insertions, 2 deletions
diff --git a/src/.clang-tidy b/src/.clang-tidy
index 3c8a24d7..331ec702 100644
--- a/src/.clang-tidy
+++ b/src/.clang-tidy
@@ -4,7 +4,6 @@
Checks: >
-*-magic-numbers,
-bugprone-easily-swappable-parameters,
- -bugprone-suspicious-string-compare,
-cert-err33-c,
-clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,
-concurrency-mt-unsafe,
diff --git a/src/uri.c b/src/uri.c
index 55e8db47..151f63e3 100644
--- a/src/uri.c
+++ b/src/uri.c
@@ -17,7 +17,7 @@ serd_uri_to_path(const uint8_t* uri)
{
const uint8_t* path = uri;
if (!is_windows_path(uri) && serd_uri_string_has_scheme(uri)) {
- if (strncmp((const char*)uri, "file:", 5)) {
+ if (!!strncmp((const char*)uri, "file:", 5)) {
fprintf(stderr, "Non-file URI `%s'\n", uri);
return NULL;
}